validatedb icon indicating copy to clipboard operation
validatedb copied to clipboard

Failure with released validatedb and dev dbplyr

Open mgirlich opened this issue 3 years ago • 4 comments

We see

  • checking tests ...
      Running ‘testthat.R’
     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      ! Object `y` not found.
      ── Error (test-summary.R:32:5): summary: works with failing rules ──────────────
      Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y > 
          0)`: Problem while computing `fail = !y > 0`
      Caused by error:
      ! Object `y` not found.
      ── Error (test-summary.R:73:5): summary: works with failing rules (sparse) ─────
      Error in `dplyr::transmute(tbl, row = row_number(), rule = "V5", fail = !y > 
          0)`: Problem while computing `fail = !y > 0`
      Caused by error:
      ! Object `y` not found.
    
      [ FAIL 3 | WARN 0 | SKIP 2 | PASS 26 ]
      Error: Test failures
      Execution halted
    

The problems comes from this change in dbplyr

  • Variables that are neither found in the data nor in the environment now produce an error (@mgirlich, #907).

We plan to release dbplyr soon so it would be great if you could fix this issue.

mgirlich avatar Aug 31 '22 09:08 mgirlich

@edwindj @markvanderloo Would be great if you could fix this issue

mgirlich avatar Dec 08 '22 05:12 mgirlich

dbplyr is now scheduled for release on Jan 16; please let us know if there's anything we can do to help.

hadley avatar Dec 20 '22 14:12 hadley

Ah, thanks will look into it this week (don't expect any problems solving it)

edwindj avatar Jan 04 '23 09:01 edwindj

Just a reminder that we're submitting to CRAN on Monday.

hadley avatar Jan 13 '23 14:01 hadley