array-api-tests icon indicating copy to clipboard operation
array-api-tests copied to clipboard

test_eigh filters too much (FailedHealthCheck)

Open asmeurer opened this issue 1 year ago • 2 comments

FAILED array_api_tests/test_linalg.py::test_eigh - hypothesis.errors.FailedHealthCheck: It looks like your strategy is filtering out a lot of data. Health check found 50 filtered examples but only 9 good ones. This will make your tests much slower, and also will probably distort the data generation quite a lot. You should adapt your strategy to filter less. This can also be caused by a low max_leaves parameter in recursive() calls See https://hypothesis.readthedocs.io/en/latest/healthchecks.html for more information about this. If you want to disable just this health check, add HealthCheck.filter_too_much to the suppress_health_check settings for this test.

asmeurer avatar Jul 01 '24 18:07 asmeurer

Haven't seen this recently. If it shows up again, we should look into it. Otherwise, as long as it doesn't happen, it's not a problem.

asmeurer avatar Nov 14 '24 22:11 asmeurer

Added a quick fix in https://github.com/data-apis/array-api-tests/pull/325. There's a TODO item in code comments to restore the range of values in a way that does not trigger the hypothesis health check.

ev-br avatar Dec 04 '24 14:12 ev-br