node-dat-archive icon indicating copy to clipboard operation
node-dat-archive copied to clipboard

DatArchive.fork added

Open ar-naseef opened this issue 7 years ago • 4 comments

ar-naseef avatar Jun 08 '18 13:06 ar-naseef

Would you mind adding a unit test for this? [https://github.com/beakerbrowser/node-dat-archive/blob/master/test/api.js]

I think a simple test would be to create an archive, write a file, fork it, and check that you can read the file from the fork.

Maybe also add a test to check the manifest

RangerMauve avatar Jun 08 '18 14:06 RangerMauve

Appreciate the PR! Yeah I agree, a unit test would be good. There's some additional logic in Beaker that might need to get copied over. See https://github.com/beakerbrowser/beaker/blob/master/app/background-process/networks/dat/library.js#L215

pfrazee avatar Jun 08 '18 20:06 pfrazee

@pfrazee Oh snap! I should add those changes to dat-archive-web, too!

RangerMauve avatar Jun 08 '18 20:06 RangerMauve

Sure I will

ar-naseef avatar Jun 09 '18 14:06 ar-naseef