datBase icon indicating copy to clipboard operation
datBase copied to clipboard

Published 20 hours ago • verified publisher icon dat-ecosystem-archive

add paging to file list

Open joehand opened this issue 7 years ago • 4 comments

Starts adding paging to file list. Depends on yo-fs PR. Currently looks like this:

screen shot 2017-01-11 at 12 19 10

Much style!

Notes:

  • I set the current page limit to 5 for easier testing. We can increase this before merging.
  • Has prev/next buttons to control paging.

TODO:

  • [ ] Merge yo-fs PR
  • [ ] Figure out how to style

joehand avatar Jan 11 '17 20:01 joehand

hey @joehand thanks for working on this ! Sorry it never moved forward.

As far as styling goes, it makes sense to me to leave it relatively unstyled in yo-fs to make sure that folks can restyle it as they please.

okdistribute avatar Feb 23 '17 01:02 okdistribute

@joehand @karissa What's the status of this? Is just styling missing from it to be merged?

Kriesse avatar Jun 15 '17 08:06 Kriesse

We were waiting for the new hyperdrive, which is now out. This issue has a bit more discussion.

Part of the blocker was that the metadata download was too slow before. We are still fetching the whole metadata upfront, but this is probably fine now. To move forward I could:

  1. Update this PR and merge as is (with the full metadata fetch)
  2. Change to partial metadata fetching and update PR (bigger task, but better long-run)

joehand avatar Jun 15 '17 16:06 joehand

Nice, thanks for circling back around on this @joehand .. I'd say do the first one, and then open an issue for making it more efficient.

okdistribute avatar Jun 17 '17 04:06 okdistribute