radeon-scripts icon indicating copy to clipboard operation
radeon-scripts copied to clipboard

Rewrite to be more CLI friendly

Open dasunsrule32 opened this issue 5 years ago • 2 comments

I want to rewrite the scripts with the following in mind:

  • Rename scripts to amd-*, since this will bring the inclusion of other cards into the fold
  • CLI Switches
  • Array to hold custom pstate|clock|voltage values, this will allow for more cards, more easily, without having to store every cards hardware defaults
  • Stop using power_dpm_state, as it's only provided for backwards compatibility. Should only be using power_dpm_force_performance_level going forward

Example idea(s) for amd-power-control:

amd-power-control -h - Function to list out help amd-power-control -r - Function to reset to default, include c to commit change to default card values amd-power-control -p - Function to set power_dpm_force_performance_level: auto, low, high, manual amd-power-control -l - Function to set a custom profile using power_dpm_force_performance_level: profile_standard, profile_min_sclk, profile_min_mclk, profile_peak amd-power-control -s - Function to set GPU clock pstate/clock/voltage level amd-power-control -m - Function to set memory clock pstate/clock level amd-power-control -v - Function to set memory clock pstate/voltage level amd-power-control -i - Function to get current card settings amd-power-control -c - Set powercap

dasunsrule32 avatar Mar 13 '19 02:03 dasunsrule32

My thoughts regarding the name: First of all this should really be amdgpu-*, since AMD has also CPUs... Secondly "power control" is only one of the functions the script offer, so I don't feel that *-power-control represents this very good (also it is kinda long). Since this script allows you to (fine) tune your card, my first choice would be amdgpu-tuner. But *-tool, *-util could also work.

Regarding the switches -i for info (e.g. cat $SYSPATH/pp_od_clk_voltage and more) for -s and -m you would need to enter the clock/voltages values in pairs, or introduce -v switch. Switches for loading and storing settings to file.

Lastly, it would be very nice if the script would communicate with a daemon (running as root), so that we can use the tool as a simple user (no sudo required).

famo avatar Mar 14 '19 19:03 famo

All good suggestions. I was already looking at adding something similar to a -v switch as you mentioned. I did forget about the -i switch though. Good suggestion.

dasunsrule32 avatar Mar 16 '19 22:03 dasunsrule32