distributed icon indicating copy to clipboard operation
distributed copied to clipboard

Multi-platform mypy checks

Open crusaderky opened this issue 3 years ago • 3 comments

Add Windows-specific mypy checks to CI. Reverts #7091

crusaderky avatar Sep 30 '22 11:09 crusaderky

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 8m 13s :stopwatch: - 37m 16s   3 152 tests ±0    3 067 :heavy_check_mark: +1    85 :zzz: ±0  0 :x:  - 1  23 328 runs   - 1  22 419 :heavy_check_mark: +6  909 :zzz:  - 6  0 :x:  - 1 

Results for commit 1a483898. ± Comparison against base commit 7c06377d.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 30 '22 11:09 github-actions[bot]

How would we get mypy to like these constants?

jakirkham avatar Sep 30 '22 15:09 jakirkham

How would we get mypy to like these constants?

As per everything mypy, we don't since mypy does not execute any code; it just searches for very specific explicit, hardcoded tests such as this or if isinstance(... or assert isinstance(...)

crusaderky avatar Sep 30 '22 16:09 crusaderky

Just merged main which should resolve the (unrelated) gpuCI failure

jrbourbeau avatar Oct 03 '22 17:10 jrbourbeau