distributed icon indicating copy to clipboard operation
distributed copied to clipboard

TaskGroupProgress stresses the scheduler

Open mrocklin opened this issue 3 years ago • 1 comments

I'm seeing 70% usage, targetting this line:

                line_renderer = self.root.line(
                    x="time",
                    y=stack(*stackers[: i + 1]),
                    color=color,
                    alpha=1.0,
                    source=self.source,
                )

cc @ian-r-rose

mrocklin avatar Sep 21 '22 00:09 mrocklin

Thanks for the report -- I'm not entirely surprised, since this draws a lot of fairly detailed glyphs. The good news is that this component only registers things on first open, so whatever performance hit might happen isn't incurred without the plot active.

I'm a little surprised that it's targeting just the line glyphs, since we're drawing both lines and areas in a very similar manner: https://github.com/dask/distributed/blob/34042bef503eac9c4794f3941c6554e3457521ed/distributed/dashboard/components/scheduler.py#L3044-L3062

I'll poke at it to see if anything obvious falls out. Edit: looking at it again, I do see some opportunities for doing a bit less work, but it would still involve drawing the same glyphs, so I'm unsure how much of an improvement it would make.

ian-r-rose avatar Sep 21 '22 15:09 ian-r-rose