distributed icon indicating copy to clipboard operation
distributed copied to clipboard

Fix sending event messages to non-subscribers

Open lwatt opened this issue 2 years ago • 4 comments

Closes https://github.com/dask/distributed/issues/7013

  • [x] Tests added / passed
  • [x] Passes pre-commit run --all-files

lwatt avatar Sep 07 '22 10:09 lwatt

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

GPUtester avatar Sep 07 '22 10:09 GPUtester

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±    0         15 suites  ±0   6h 13m 7s :stopwatch: + 14m 16s   3 151 tests +  60    3 058 :heavy_check_mark: +  57    85 :zzz:  -   3    8 :x: +  6  23 315 runs  +501  22 379 :heavy_check_mark: +498  913 :zzz:  - 18  23 :x: +21 

For more details on these failures, see this check.

Results for commit 43a9cbdf. ± Comparison against base commit 3655f136.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Sep 07 '22 10:09 github-actions[bot]

Thanks - I've added a test now. Confirmed this fails on the original version, and passes now.

lwatt avatar Sep 08 '22 08:09 lwatt

I've just pushed the linting updates from pre-commit. It would be great if this could be merged soon

lwatt avatar Sep 09 '22 17:09 lwatt

@lwatt I was bothered by this today. Thanks for the fix! I see this PR was approved. Could we merge it now?

hiiwave avatar Dec 09 '22 20:12 hiiwave