distributed icon indicating copy to clipboard operation
distributed copied to clipboard

Reduce recursionlimit for `test_client.py::test_profile`

Open fjetter opened this issue 2 years ago • 1 comments

I don't really understand fully what's going on but we've seen some fatal windows errors on CI with this. This should never happen since the merge actually catches a RecursionError and aborts. This is clearly not the most elegant solution but a practical one. For this flaky test I do not intend to rewrite how we merge frames in our profiler and I think it's perfectly fine to force this exception earlier before we hit an actual stackoverflow that terminates the interpreter

fjetter avatar Aug 09 '22 14:08 fjetter

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±    0         15 suites  ±0   6h 26m 34s :stopwatch: - 6m 46s   2 992 tests ±    0    2 901 :heavy_check_mark:  -     2       89 :zzz: ±  0  2 :x: +2  22 189 runs   - 589  21 136 :heavy_check_mark:  - 514  1 049 :zzz:  - 79  4 :x: +4 

For more details on these failures, see this check.

Results for commit c52d180f. ± Comparison against base commit 99a2db1c.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 09 '22 15:08 github-actions[bot]