distributed
distributed copied to clipboard
Inserting memory_limit parameter within LocalCluster docstring
Insert memory_limit parameter into the LocalCluster docstring and adding notes that the argument:
- Sets memory limit per worker
- Cannot exceed the total memory available
Closes #8224
- [ ] Tests added / passed
- [ ] Passes
pre-commit run --all-files
Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.
Addresses issue #8224
Unit Test Results
See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.
15 files ± 0 15 suites ±0 6h 22m 40s :stopwatch: - 10m 10s 3 005 tests +16 2 922 :heavy_check_mark: + 23 83 :zzz: - 5 0 :x: - 2 22 239 runs +73 21 272 :heavy_check_mark: +158 967 :zzz: - 81 0 :x: - 4
Results for commit 6af4fa8d. ± Comparison against base commit d6160c89.
:recycle: This comment has been updated with latest results.
add to allowlist
These are good suggestions and I'll be sure to address the comments by @gjoseph92 in the docstring for memory_limit. Do let me know if these are sufficient changes for the issue to be approved or if anything else is missing!
I managed to fix the linting/pre-commit hooks errors after double checking the error messages. Let me know if there's anything else!
Is there anything more to be done here, or is this ready to merge?
Thanks for the review @gjoseph92 !
Thanks @gjoseph92, glad to see my first merge on here!