distributed icon indicating copy to clipboard operation
distributed copied to clipboard

Run test suite with dev version of `bokeh`

Open jrbourbeau opened this issue 3 years ago • 5 comments

xref https://github.com/dask/distributed/pull/6707

jrbourbeau avatar Jul 11 '22 19:07 jrbourbeau

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 54m 2s :stopwatch: + 30m 44s   3 086 tests ±0    2 988 :heavy_check_mark:  - 12    85 :zzz: +1  13 :x: +11  22 834 runs  ±0  21 758 :heavy_check_mark:  - 89  985 :zzz: ±0  91 :x: +89 

For more details on these failures, see this check.

Results for commit 10767d66. ± Comparison against base commit bfc5cfea.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Jul 11 '22 22:07 github-actions[bot]

@bryevdv it looks like these are the following things that are popping up in CI when using the nightly bokeh conda package:

AttributeError: module 'bokeh.plotting' has no attribute 'Figure'
TypeError: linear_cmap() got an unexpected keyword argument 'field_name'
 bokeh.util.warnings.BokehDeprecationWarning: on_click(handler) was deprecated in Bokeh 3.0.0 and will be removed, use on_event("button_click", handler) instead.
bokeh.util.warnings.BokehDeprecationWarning: CDSView.filters was deprecated in bokeh 3.0. Use CDSView.filter instead.

jrbourbeau avatar Jul 12 '22 21:07 jrbourbeau

AttributeError: module 'bokeh.plotting' has no attribute 'Figure'

Redundant and removed, everything should use figure (lower-f) but I will see if we can't add a module getter to afford a deprecated Figure back

TypeError: linear_cmap() got an unexpected keyword argument 'field_name'

This was evidently changed to just field but I am not sure for what good reason, I will open an issue to propose restoring it as before

The deprecations will continue to work, but it would be good to update them any time after Dask sets Bokeh 3.0 as the min version.

bryevdv avatar Jul 12 '22 22:07 bryevdv

@jrbourbeau can you try to confirm that these errors are not just test-only issues, and that they affect real codepaths?

bryevdv avatar Jul 12 '22 22:07 bryevdv

@jrbourbeau I am submitting a PR to revert the field_name rename. I think the Figure issue is test-only:

143:    assert isinstance(figure, bokeh.plotting.Figure)
158:    assert isinstance(ts.figure, bokeh.plotting.Figure)

So I think that can be handled on this end.

bryevdv avatar Jul 14 '22 01:07 bryevdv