dask icon indicating copy to clipboard operation
dask copied to clipboard

Optimize the push method when the limit (n) parameter is used

Open josephnowak opened this issue 1 year ago • 1 comments

  • [x] Closes #xxxx
  • [x] Tests added / passed
  • [x] Passes pre-commit run --all-files

@phofl here is the PR to optimize the push method based on the discussion that we had in this PR.

The main problem that I found was that there is no nanlast method on Dask, should I copy the logic from Xarray to this repository? or is it okay for now to use the sequential method by default to avoid adding the nanlast?

josephnowak avatar Nov 22 '24 15:11 josephnowak

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     15 files  +     2       15 suites  +2   4h 8m 33s ⏱️ + 40m 7s  13 256 tests ±     0   12 194 ✅ ±     0   1 062 💤 ±    0  0 ❌ ±0  164 446 runs  +26 118  141 526 ✅ +22 195  22 920 💤 +3 923  0 ❌ ±0 

Results for commit f3465ce3. ± Comparison against base commit 4814464b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Nov 22 '24 16:11 github-actions[bot]