dask-ml icon indicating copy to clipboard operation
dask-ml copied to clipboard

Implement make_s_curve

Open CC-Yeh opened this issue 2 years ago • 0 comments

Hi everyone,

I implemented a make_s_curve function and corresponding tests for it.

However, one of the tests is currently failing consistently, even though I have verified the values in the outputs and the computation graph. Appreciate any feedback or suggestions on how to resolve this issue.

The test that failed.

@pytest.mark.parametrize(
    "generator",
    [
        dask_ml.datasets.make_blobs,
        dask_ml.datasets.make_classification,
        dask_ml.datasets.make_counts,
        dask_ml.datasets.make_regression,
        dask_ml.datasets.make_s_curve,
    ],
)
def test_deterministic(generator, scheduler):
    a, t = generator(chunks=100, random_state=10)
    b, u = generator(chunks=100, random_state=10)
    assert_eq(a, b)
    assert_eq(t, u)

CC-Yeh avatar Apr 02 '23 20:04 CC-Yeh