dask-jobqueue icon indicating copy to clipboard operation
dask-jobqueue copied to clipboard

[WIP] Attempt to make job submission async

Open oshadura opened this issue 4 years ago • 3 comments

Probably fixes: #470 cc: @bbockelm

oshadura avatar Nov 13 '20 14:11 oshadura

Some CI error looks genuine for example this one: https://github.com/dask/dask-jobqueue/pull/473/checks?check_run_id=1406501917.

I am not an async expert, but I would guess you need to add some await where _call is called, maybe changing the functions calling _call to async. One such function seems to be _job_id_from_submit_output, there may be others. In an ideal world, the main user-facing functions would stay synchronous so that if you get an exception it blows up in an obvious way rather than having some log message saying that an exception was never retrieved.

Full disclosure : unfortunately I don't really understand the original issue #470 ...

lesteve avatar Nov 17 '20 09:11 lesteve

This PR is a bit old... @oshadura are you still around and up for this change?

I'm going to close this one next time I'll take a look at the activity here, unless someone updates it.

guillaumeeb avatar Aug 31 '21 14:08 guillaumeeb

@guillaumeeb sorry I was working on other things and thanks for reminder! I will definitely try to take a look in next couple of days and update/close PR.

oshadura avatar Sep 01 '21 14:09 oshadura