dask-image icon indicating copy to clipboard operation
dask-image copied to clipboard

Relaxed type check of input array, to allow da.core.Array sub-classes…

Open sommerc opened this issue 1 year ago • 4 comments

For some file formats aicsimageio and nd2 return a sub-class of da.core.Array: ResourceBackedDaskAray

This PR relaxes the input type check to allow da.core.Array sub-classes in ndinterp functions.

Closes #360

sommerc avatar Apr 22 '24 12:04 sommerc

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

GPUtester avatar Apr 22 '24 12:04 GPUtester

add to allowlist

m-albert avatar Apr 22 '24 12:04 m-albert

Thanks for the PR @sommerc 🙏

There's an error showing up in the tests that's unrelated to this PR, so we'll need to get the associated issue https://github.com/dask/dask-image/issues/362 fixed to turn the tests green here.

m-albert avatar Apr 22 '24 13:04 m-albert

Thanks you @m-albert! Let me know if I can do sth.

btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed

sommerc avatar Apr 23 '24 08:04 sommerc

btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed

fyi I've fixed this particular problem in the main branch now 😄

GenevieveBuckley avatar May 14 '24 08:05 GenevieveBuckley

This is a very useful change to have, thank you for contributing @sommerc 🎉

GenevieveBuckley avatar May 14 '24 09:05 GenevieveBuckley

Very small, but indeed usefull when data come from aicsimageio :-)

Thank you guys for your time and efforts in providing such a great resource!

sommerc avatar May 14 '24 10:05 sommerc