dask-image
dask-image copied to clipboard
Relaxed type check of input array, to allow da.core.Array sub-classes…
For some file formats aicsimageio and nd2 return a sub-class of da.core.Array: ResourceBackedDaskAray
This PR relaxes the input type check to allow da.core.Array sub-classes in ndinterp functions.
Closes #360
Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.
add to allowlist
Thanks for the PR @sommerc 🙏
There's an error showing up in the tests that's unrelated to this PR, so we'll need to get the associated issue https://github.com/dask/dask-image/issues/362 fixed to turn the tests green here.
Thanks you @m-albert! Let me know if I can do sth.
btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed
btw. I noticed problems using current pytest >= 8.0. And had to pin pytest < 8.0. In the current version of pytest the signature of pytest.skip() has changed
fyi I've fixed this particular problem in the main branch now 😄
This is a very useful change to have, thank you for contributing @sommerc 🎉
Very small, but indeed usefull when data come from aicsimageio :-)
Thank you guys for your time and efforts in providing such a great resource!