dask-image icon indicating copy to clipboard operation
dask-image copied to clipboard

Running test suite as part of PyPI release #147

Open tkoyama010 opened this issue 5 years ago • 4 comments

Running test suite as part of PyPI release #147 This is a sprint contribution in ScipyJapan2020 (#163) .

tkoyama010 avatar Nov 02 '20 03:11 tkoyama010

Oh my. Test script which we created in #172 seems not working :cry: https://github.com/dask/dask-image/pull/175/checks?check_run_id=1340168042

tkoyama010 avatar Nov 02 '20 04:11 tkoyama010

~~Before reviewing this Pull Request, please review see #176 :bow:~~

tkoyama010 avatar Nov 02 '20 04:11 tkoyama010

Now it is ready for review :rocket:

tkoyama010 avatar Nov 02 '20 06:11 tkoyama010

Thanks @GenevieveBuckley for your review.

tkoyama010 avatar Nov 02 '20 07:11 tkoyama010

I'm going to close this PR in favour of https://github.com/dask/dask-image/pull/291 The advantage with that is:

  • there will be no difference between the regular test CI, and the tests that are run just before the new release is uploaded to PyPI
  • it will also test all operating systems (Windows, Mac, and Linux) instead of just on Linux

GenevieveBuckley avatar Mar 14 '23 05:03 GenevieveBuckley

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

GPUtester avatar Mar 14 '23 05:03 GPUtester

Thanks again for all your help @tkoyama010!

GenevieveBuckley avatar Mar 14 '23 05:03 GenevieveBuckley