dask-glm
dask-glm copied to clipboard
dask
Deprecate estimators
I won’t be able to update this in the near future. If anyone is able to push it through I’d appreciate it.
From: James Bourbeau [email protected] Sent: Wednesday, March 20, 2019 10:07 AM To: dask/dask-glm Cc: Tom Augspurger; Mention Subject: Re: [dask/dask-glm] Deprecate estimators (#66)
@jrbourbeau commented on this pull request.
Thanks for updating this @TomAugspurgerhttps://github.com/TomAugspurger!
I added two comments for updated documentation links. There are also a couple of things flake8 doesn't like. Otherwise LGTM
In docs/index.rsthttps://github.com/dask/dask-glm/pull/66#discussion_r267384797:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
.. _GLM: https://en.wikipedia.org/wiki/Generalized_linear_model
.. _scikit-learn: http://scikit-learn.org/
+.. _dask-ml: http://dask-ml.readthedocs.org/
⬇️ Suggested change
-.. _dask-ml: http://dask-ml.readthedocs.org/
+.. _dask-ml: https://ml.dask.org/
In docs/index.rsthttps://github.com/dask/dask-glm/pull/66#discussion_r267384989:
@@ -30,3 +30,4 @@ Indices and tables
.. _dask: http://dask.pydata.org/en/latest/
⬇️ Suggested change
- .. _dask: http://dask.pydata.org/en/latest/
+.. _dask: https://docs.dask.org/
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dask/dask-glm/pull/66#pullrequestreview-216778670, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQHIuPtjqNTz7-pElHaZD4o-SiUbOd4ks5vYk6pgaJpZM4Qf2qr.