dask-glm icon indicating copy to clipboard operation
dask-glm copied to clipboard

Published 20 hours ago • verified publisher icon dask

ABC for Families

Open postelrich opened this issue 7 years ago • 5 comments

This PR adds an abstract base class for distribution families. To provide the same way to track subclasses as Regularizers, I added a RegistryClass that both abc's can inherit.

postelrich avatar May 17 '17 16:05 postelrich

@moody-marlin @TomAugspurger feedback before I add tests?

postelrich avatar May 22 '17 16:05 postelrich

Nice, I like the organization and consistency this brings.

cicdw avatar May 22 '17 16:05 cicdw

@postelrich are you planning on adding more tests, or are you comfortable merging?

cicdw avatar May 24 '17 17:05 cicdw

@moody-marlin im going to add tests

postelrich avatar May 24 '17 18:05 postelrich

@postelrich want to revisit this and get the tests passing?

cicdw avatar Jul 17 '17 22:07 cicdw