dask-sql
dask-sql copied to clipboard
Support `to_timestamp`
Closes #831.
Codecov Report
Merging #838 (be05bac) into main (ab246b0) will increase coverage by
0.00%. The diff coverage is57.69%.
@@ Coverage Diff @@
## main #838 +/- ##
=======================================
Coverage 75.50% 75.51%
=======================================
Files 73 73
Lines 3985 4011 +26
Branches 713 721 +8
=======================================
+ Hits 3009 3029 +20
+ Misses 818 817 -1
- Partials 158 165 +7
| Impacted Files | Coverage Δ | |
|---|---|---|
| dask_sql/physical/rex/core/call.py | 80.04% <57.69%> (-1.30%) |
:arrow_down: |
| dask_sql/_version.py | 35.31% <0.00%> (+1.41%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I'm not quite sure why test_fsql is consistently failing at https://github.com/dask-contrib/dask-sql/blob/main/tests/integration/test_fugue.py#L67
I'm not quite sure why
test_fsqlis consistently failing at https://github.com/dask-contrib/dask-sql/blob/main/tests/integration/test_fugue.py#L67
I saw this pop up on a some tests unrelated to this pr: https://github.com/dask-contrib/dask-sql/actions/runs/3292477865/attempts/1.
They seem to be presenting only on Mac-os so far and seems intermittent. Might need to investigate further if this keeps showing up.
Also looking through the postgresql docs the integer version of this method doesn't accept a
formatargument. Do you think it's possible to update the parser to handle this? If not we might need to either throw an error or ignore the format for integer cases.
Interesting, thanks! Yes, this should be easy to fix, so I can update this as well.