dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Replace `dask_ml.wrappers.ParallelPostFit` with custom `ParallelPostFit` class

Open sarahyurick opened this issue 3 years ago • 2 comments

As part of our initiative to move away from Dask-ML, I've migrated some code from Dask-ML into Dask-SQL to support ParallelPostFit.

sarahyurick avatar Sep 30 '22 22:09 sarahyurick

Codecov Report

Merging #832 (ef087db) into main (d9fc2c1) will decrease coverage by 2.10%. The diff coverage is 30.16%.

@@            Coverage Diff             @@
##             main     #832      +/-   ##
==========================================
- Coverage   77.44%   75.33%   -2.11%     
==========================================
  Files          71       72       +1     
  Lines        3600     3779     +179     
  Branches      634      674      +40     
==========================================
+ Hits         2788     2847      +59     
- Misses        685      795     +110     
- Partials      127      137      +10     
Impacted Files Coverage Δ
dask_sql/physical/rel/custom/wrappers.py 28.07% <28.07%> (ø)
dask_sql/physical/rel/custom/create_model.py 88.70% <66.66%> (-2.82%) :arrow_down:
dask_sql/physical/rel/custom/create_experiment.py 96.15% <100.00%> (-0.10%) :arrow_down:
dask_sql/_version.py 35.31% <0.00%> (+2.74%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 30 '22 22:09 codecov-commenter

Let me know if you think any tests from Dask-ML's tests/test_parallel_post_fit.py or from https://github.com/dask/dask-ml/pull/912 should be added.

sarahyurick avatar Oct 05 '22 16:10 sarahyurick