dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Implement basic COALESCE functionality

Open ChrisJar opened this issue 3 years ago • 1 comments

ChrisJar avatar Sep 29 '22 20:09 ChrisJar

Will depend on https://github.com/dask/dask/pull/9563 and related dask-cudf work

randerzander avatar Oct 11 '22 17:10 randerzander

Codecov Report

Merging #823 (22cf6ad) into main (d2896fa) will increase coverage by 0.26%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
+ Coverage   75.67%   75.94%   +0.26%     
==========================================
  Files          73       73              
  Lines        4050     4065      +15     
  Branches      731      737       +6     
==========================================
+ Hits         3065     3087      +22     
+ Misses        824      814      -10     
- Partials      161      164       +3     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/aggregate.py 90.10% <100.00%> (+0.10%) :arrow_up:
dask_sql/physical/rex/core/call.py 81.50% <100.00%> (+0.47%) :arrow_up:
dask_sql/_version.py 35.31% <0.00%> (+1.41%) :arrow_up:
dask_sql/mappings.py 89.21% <0.00%> (+1.96%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 23 '22 19:11 codecov-commenter

@ChrisJar are the changes in https://github.com/dask/dask/pull/9563 only needed to enable this functionality on gpu's or is this needed for this functionality in general?

ayushdg avatar Nov 30 '22 20:11 ayushdg

Those changes are actually not needed for this PR at all. I ended up taking a different path.

ChrisJar avatar Nov 30 '22 20:11 ChrisJar