dask-sql
dask-sql copied to clipboard
Update dockerfile setup to use mamba
With packaging updates for different min versions in dask-sql the conda solver fails to solve properly in our dockerfile setup. Switching to mamba seems to resolve this.
Codecov Report
Merging #583 (3c6be77) into main (0db4506) will increase coverage by
0.14%. The diff coverage isn/a.
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
+ Coverage 88.45% 88.60% +0.14%
==========================================
Files 69 69
Lines 3500 3500
Branches 707 707
==========================================
+ Hits 3096 3101 +5
+ Misses 317 308 -9
- Partials 87 91 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| dask_sql/_version.py | 34.00% <0.00%> (+1.44%) |
:arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more
@ayushdg this is marked as a draft but seems ready. Are you ready for a review?
@ayushdg this is marked as a draft but seems ready. Are you ready for a review? Not yet. The core issues is fixed but I'm also trying to update GitHub actions to test docker changes if those files are touched and I need to resolve some issues there.
This isn't my area of expertise but wanted to say thank you @ayushdg because I will definitely be consuming this and benefiting!
Going through the errors. It looks like docker cloud step still seems to be trying to fetch some image information from docker hub instead of using the image that is present locally (loaded at the previous step). Pinging @jacobtomlinson in case you have any suggestions on how we can use the image generated in the main step for a subsequent step without pushing to docker hub.