dask-sql
dask-sql copied to clipboard
Remove some logger / deprecation warnings
Closes #391
This PR switches around some of the logger / warnings in an effort to make warnings less intrusive to users, while also removing some deprecation code that is pretty old and likely isn't encountered anymore.
Side note - is anyone actively using the logging functionality here? If not, maybe it would just be better to remove the majority of the debugging logs from the code altogether, and just stick to warnings.warn for the few cases where we actually need to warn the user of something? cc @jdye64 as I know you were doing some work with the logging
Codecov Report
Merging #426 (e6bcfca) into main (5beaf35) will decrease coverage by
0.04%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 89.03% 88.98% -0.05%
==========================================
Files 69 69
Lines 3328 3323 -5
Branches 654 654
==========================================
- Hits 2963 2957 -6
+ Misses 296 293 -3
- Partials 69 73 +4
| Impacted Files | Coverage Δ | |
|---|---|---|
| dask_sql/java.py | 100.00% <ø> (ø) |
|
| dask_sql/physical/rel/logical/filter.py | 88.88% <ø> (ø) |
|
| dask_sql/context.py | 100.00% <100.00%> (ø) |
|
| dask_sql/physical/rel/logical/join.py | 98.30% <100.00%> (-0.02%) |
:arrow_down: |
| dask_sql/_version.py | 32.27% <0.00%> (-0.29%) |
:arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more