dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

[DOC] Error with Binder link

Open scharlottej13 opened this issue 3 years ago • 4 comments

Report incorrect documentation

Location of incorrect documentation There is an error loading binder in the link provided in the Quickstart section of the readme.

Describe the problems or issues found in the documentation The error message is Error loading dask-contrib/dask-sql-binder/main! See logs below for details. and the logs show: Could not resolve ref for gh:dask-contrib/dask-sql-binder/main. Double check your URL. GitHub recently changed default branches from "master" to "main". Did you mean the "master" branch?

Steps taken to verify documentation is incorrect I looked in the repo for where the binder files might live, but didn't find them

scharlottej13 avatar Mar 07 '22 21:03 scharlottej13

Thanks for raising the issue @scharlottej13!

Looks like the original binder repository for this repo lives here: https://github.com/nils-braun/dask-sql-binder. @charlesbluca it might make sense to create an equivalent repo in dask-contrib and build on the initial work done by Nils.

ayushdg avatar Mar 07 '22 22:03 ayushdg

Happy to take this on!

ayushdg avatar Mar 07 '22 23:03 ayushdg

I definitely think relocating these notebooks to a more public location where we can continue contributing to it is a great idea - wondering if maybe a better place to relocate these notebooks would be dask-examples? Looking at Dask-ML's binder link, it seems to use the binder generated there with a filepath to specify the notebook to load into.

EDIT:

Will also note that there was a WIP to get a dask-sql notebook added there https://github.com/dask/dask-examples/pull/171

charlesbluca avatar Mar 08 '22 20:03 charlesbluca

That seems like a possible options as well. Here's what I have so far:

  1. Move notebooks to Dask-examples and add dask-sql as requirement to dask-examples.
  2. Move notebooks and environment to a new repository or dask-sql itself.
  3. Move notebooks to dask-examples but create environment elsewhere (dask-sql/new repo).

Option 1 looks like the best one so far.

ayushdg avatar Mar 09 '22 02:03 ayushdg