dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Add better partition string escaping

Open gallamine opened this issue 4 years ago • 3 comments

Based on the https://github.com/nils-braun/dask-sql/issues/179 this PR adds string escaping to non-integer partition values. Partitions like:

forecasted_business_day=2021-05-27

will now be wrapped like

forecasted_business_day="2021-05-27"

when executing the SQL

gallamine avatar May 19 '21 20:05 gallamine

Codecov Report

Merging #180 (cdc603e) into main (bbfee5f) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #180   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           57        57           
  Lines         2209      2210    +1     
  Branches       303       303           
=========================================
+ Hits          2209      2210    +1     
Impacted Files Coverage Δ
dask_sql/input_utils/hive.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbfee5f...cdc603e. Read the comment docs.

codecov-commenter avatar May 20 '21 06:05 codecov-commenter

Thank you so much @gallamine! I have added some thoughts to https://github.com/gallamine/dask-sql/pull/1 on that and #181. I think we need to solve both issues at the same time.

nils-braun avatar May 20 '21 06:05 nils-braun

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

GPUtester avatar Sep 01 '22 01:09 GPUtester