Add better partition string escaping
Based on the https://github.com/nils-braun/dask-sql/issues/179 this PR adds string escaping to non-integer partition values. Partitions like:
forecasted_business_day=2021-05-27
will now be wrapped like
forecasted_business_day="2021-05-27"
when executing the SQL
Codecov Report
Merging #180 (cdc603e) into main (bbfee5f) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 2209 2210 +1
Branches 303 303
=========================================
+ Hits 2209 2210 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| dask_sql/input_utils/hive.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bbfee5f...cdc603e. Read the comment docs.
Thank you so much @gallamine! I have added some thoughts to https://github.com/gallamine/dask-sql/pull/1 on that and #181. I think we need to solve both issues at the same time.
Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.