dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Use aliased column names for cross joins

Open charlesbluca opened this issue 2 years ago • 1 comments

Because we were forgetting to alias/unalias column names before/after the merge operation, tables sharing column names were not being handled properly

charlesbluca avatar Oct 25 '23 15:10 charlesbluca

Codecov Report

Merging #1250 (df198d1) into main (3972967) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1250   +/-   ##
=======================================
  Coverage   85.55%   85.56%           
=======================================
  Files          77       77           
  Lines        4258     4260    +2     
  Branches      758      758           
=======================================
+ Hits         3643     3645    +2     
  Misses        446      446           
  Partials      169      169           
Files Coverage Δ
dask_sql/physical/rel/logical/cross_join.py 88.88% <100.00%> (+0.88%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Oct 25 '23 16:10 codecov-commenter