dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Refactor assignment logic to aliasing same column multiple times on GPU

Open charlesbluca opened this issue 2 years ago • 1 comments

Refactors our DataContainer.assign logic to avoid creating a dataframe with multiple columns on GPU, which silently fails and causes errors later down the road.

Closes #1133

charlesbluca avatar May 04 '23 19:05 charlesbluca

Codecov Report

Merging #1134 (aca4a44) into main (108e024) will decrease coverage by 0.17%. The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1134      +/-   ##
==========================================
- Coverage   81.42%   81.25%   -0.17%     
==========================================
  Files          78       78              
  Lines        4392     4390       -2     
  Branches      796      796              
==========================================
- Hits         3576     3567       -9     
- Misses        639      640       +1     
- Partials      177      183       +6     
Impacted Files Coverage Δ
dask_sql/datacontainer.py 95.45% <100.00%> (-0.09%) :arrow_down:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar May 04 '23 19:05 codecov-commenter