dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Introduce `gpu` kwarg to `Context.__init__`, deprecate for `create_table`

Open charlesbluca opened this issue 2 years ago • 1 comments

Having a GPU flag set at the context level should allow us to more easily make assumptions when doing things such as:

  • creating tables on the fly (i.e., AnalyzeTable or EmptyRelation plugins)
  • setting SQL to Python type mappings (xref #1073)
  • tune queries mid-execution to optimize for performance

Assume the majority of the work here will be test refactoring to get things passing, but hopeful that this will make it a little easier to generalize CPU/GPU tests moving forward.

charlesbluca avatar Apr 12 '23 07:04 charlesbluca

Codecov Report

Merging #1117 (a3019a2) into main (c8a3234) will decrease coverage by 0.24%. The diff coverage is 72.41%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1117      +/-   ##
==========================================
- Coverage   81.76%   81.52%   -0.24%     
==========================================
  Files          78       78              
  Lines        4397     4443      +46     
  Branches      792      801       +9     
==========================================
+ Hits         3595     3622      +27     
- Misses        631      637       +6     
- Partials      171      184      +13     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/aggregate.py 88.35% <0.00%> (-2.90%) :arrow_down:
dask_sql/utils.py 96.49% <50.00%> (-2.59%) :arrow_down:
dask_sql/context.py 91.91% <63.15%> (-1.87%) :arrow_down:
dask_sql/physical/rel/custom/analyze_table.py 86.95% <100.00%> (-2.33%) :arrow_down:
dask_sql/physical/rel/custom/describe_model.py 87.50% <100.00%> (+0.54%) :arrow_up:
dask_sql/physical/rel/custom/show_columns.py 86.95% <100.00%> (+0.59%) :arrow_up:
dask_sql/physical/rel/custom/show_models.py 82.35% <100.00%> (+1.10%) :arrow_up:
dask_sql/physical/rel/custom/show_schemas.py 88.00% <100.00%> (+0.50%) :arrow_up:
dask_sql/physical/rel/custom/show_tables.py 86.95% <100.00%> (+0.59%) :arrow_up:
dask_sql/physical/rel/logical/empty.py 82.35% <100.00%> (+1.10%) :arrow_up:

... and 5 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Apr 18 '23 05:04 codecov-commenter