dask-sql icon indicating copy to clipboard operation
dask-sql copied to clipboard

Add support for VALUES query

Open ayushdg opened this issue 2 years ago • 3 comments

Fixes #1013

Initial attempt at supporting the Values query.

Currently limited to creating the result on cpu dataframes only but eventually plan on extending to GPU frames via some common config.

ayushdg avatar Feb 09 '23 01:02 ayushdg

Codecov Report

Merging #1038 (8df5361) into main (ab7340b) will increase coverage by 2.45%. The diff coverage is 75.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   79.08%   81.54%   +2.45%     
==========================================
  Files          78       78              
  Lines        4395     4395              
  Branches      797      797              
==========================================
+ Hits         3476     3584     +108     
+ Misses        743      628     -115     
- Partials      176      183       +7     
Impacted Files Coverage Δ
dask_sql/physical/rel/logical/values.py 77.77% <75.00%> (+44.44%) :arrow_up:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Feb 09 '23 02:02 codecov-commenter

@charlesbluca since this is also one of those cases which would benefit from cpu/gpu handling does it make sense to followup on this once #1117 is complete?

ayushdg avatar May 04 '23 20:05 ayushdg

Yeah that makes sense - also okay with merging this in as is and iterating on it in my PR if we need VALUES implemented on CPU to unblock something

charlesbluca avatar May 09 '23 13:05 charlesbluca