Fix update cargo dependencies script for Mac OS X

Open ayushdg opened this issue 2 years ago • 5 comments

The existing update-dependencies.sh script fails on Mac OS X as seen in these runs. This updates the script to use the -E as discussed in the comments here.

Jan 25 '23 14:01 ayushdg

Codecov Report

Merging #1010 (7bd4eac) into main (08cff1a) will increase coverage by 0.11%. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1010      +/-   ##
==========================================
+ Coverage   80.47%   80.59%   +0.11%     
==========================================
  Files          75       75              
  Lines        4231     4231              
  Branches      765      765              
==========================================
+ Hits         3405     3410       +5     
+ Misses        662      653       -9     
- Partials      164      168       +4

Impacted Files	Coverage Δ
dask_sql/_version.py	`35.31% <0.00%> (+1.41%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Jan 25 '23 14:01 codecov-commenter

Good point. It should be fairly straightforward to add the same logic from the rust testing to our python test matrix as well. Happy to include in this pr

Jan 25 '23 14:01 ayushdg

Happy to include in this pr

Sounds good to me

Jan 25 '23 14:01 charlesbluca

Link to a run with [test-df-upstream] enabled.

Jan 25 '23 21:01 ayushdg

@charlesbluca should be ready for another round of reviews

Jan 26 '23 15:01 ayushdg