David Ashpole

Results 719 comments of David Ashpole

@dmathieu I think this needed another approval prior to merging. @MrAlias should I revert this to give you time to review?

@MrAlias are you OK with a follow-up PR?

https://github.com/open-telemetry/opentelemetry-go/pull/7718

Can you add documentation or an example_test.go to demonstrate how someone could use this to add attributes to metrics?

There was a release, so you need to move the changelog entry up to the unreleased section. You may need to add the appropriate header if the section doesn't already...

As long as you can store a trace ID, span ID, and start time, you can probably just generate the entire span when it ends. You can set a custom...

> F. [SHOULD] Enable future Prometheus evolution for complex samples only (i.e. no classic histogram and summaries one day); allows flexibility for future changes. Have you thought about how you...