David Ashpole
David Ashpole
Here you go: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/37277
@sfc-gh-chli This will only support PRW 2.0. I would be much more challenging to implement support for V1. It was considered many times prior to PRW 2.0, but the lack...
This looks like it does a lot more than just add a labeler. Would you mind doing general refactoring in its own PR?
A few thoughts/ideas: * If we use constant labels as you propose here, what is the use-case? Are constant labels actually useful? * Should the Labeler take a stats.RPCTagInfo or...
I think this change is a good idea. @hanyuancheung any thoughts?
Sorry. We don't have any codeowners for the component, so reviews and such are likely to be much slower.
Working on tests. metrics.Read is being strange during unit testing, and seems to always return the same result.
I had to add code that allocates memory to ensure the metric actually changes for the refresh test. I ran it locally with `-count 10000`, and it passes, so hopefully...
`/gc/heap/allocs:bytes` and `/gc/heap/allocs:objects` don't seem to be populated on windows. I'm investigating
I think I got the test passing