David Ashpole

Results 356 comments of David Ashpole

I'm still not thrilled with the idea of a new code config surface when we already have one. I would prefer a solution which: * Doesn't introduce a new set...

Thats really neat. TIL. I think that makes sense to do, but I don't think it should be done in the GCP detector, since it isn't GCP-specific. Maybe we should...

I was able to get this to work when I tried it. See https://github.com/GoogleCloudPlatform/golang-samples/compare/main...dashpole:opentelemetry_demo#diff-5351ce38b44519584b4f0959dc4095b977aa13372f7873f3d82f8c70daf85236R65-R68 for how to use the resource detector. Are you installing the cloud run detector? In my...

For server spans, it would be nice to include the route as well, as described in [the spec](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.1.0/specification/trace/semantic_conventions/http.md#name). (Inspired by https://github.com/kubernetes/kubernetes/issues/112059)

There are use-cases in prometheus (e.g. collecting metrics from another metrics system), where timestamps should be used. IIRC, those aren't possible in with the current otel API (you can't specify...

> Do we want to limit Resource attributes to only attributes useful to metrics (i.e. only identifying, low-cardinality attribtues) @jsuereth maybe i'm misreading, but this seems contradictory. If a set...

There are a few motivations behind `target_info`: 1. Limiting data loss when round-tripping between Prometheus and OpenTelemetry. 2. ([mentioned](https://github.com/open-telemetry/opentelemetry-specification/issues/2640#issuecomment-1190311815) by @fstab) Parity between the data produced by a Prometheus exporter...

> I believe it would make things more streamlined if first tackle the addition of "scope" as a semantic convention concept separately from the Prometheus use-cases/changes. So, a PR only...

> If the Scope has a different namespace then why are we prefixing the attribute names by scope.? That seems unnecessary to me. It would be necessary if we decided...