refactor: import CREDITS_PER_DUFF for use in credit converter

[thephez]

Eliminates a second definition for the same constant (credits/duff ratio)

Issue being fixed or feature implemented

Credit/duff ratio was defined in two locations

What was done?

Updated credit_converter to import the credit/duff value defined elsewhere

How Has This Been Tested?

Breaking Changes

N/A

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added or updated relevant unit/integration/functional/e2e tests
• [x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• [ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• [x] I have assigned this pull request to a milestone

Summary by CodeRabbit

• Refactor
  • Revised the conversion calculations between currency units for improved consistency and robust error handling.
• Bug Fixes
  • Addressed issues ensuring that conversion outcomes—especially for very small values and potential overflow scenarios—are now accurate, with updated references to the new constant.

[coderabbitai[bot]]

Walkthrough

The conversion logic in the identity module has been updated to use the imported constant CREDITS_PER_DUFF instead of the previously defined RATIO for arithmetic operations in both conversion functions. Error handling using ok_or and the relevant test cases have been modified to reflect this change.

Changes

File Path	Change Summary
packages/rs-dpp/src/identity/credits_converter.rs	Removed local constant RATIO and replaced its usage with imported CREDITS_PER_DUFF in conversion functions and error handling. Updated test assertions accordingly.

Suggested reviewers

• shumkov
• QuantumExplorer

Poem

🐇 Hoppin' through the code, I found a brand new beat,
Farewell to old ratios, replaced to make math neat.
With CREDITS_PER_DUFF guiding each conversion street,
Overflow errors vanish as tests all come complete.
I waltz through the logic with a joyful, bouncy feat!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[thephez]

Run cargo fmt

Oh, I did. But I forgot to push it :see_no_evil:

[thephez]

@shumkov or @QuantumExplorer could you take a minute to review / merge this one? It's pretty trivial.