dashpay
DAPI getIdentityByPublicKeyHash is not working for masternode identities
Expected Behavior
DAPI GRPC query for searching an identity by specific public key hash should work for all identities in the state.
Current Behavior
Masternode identity could not be found through getIdentityByPublicKeyHash RPC, query always returns Not Found error. Regular identities can be found just fine.
The query should work transparently to the user independently which type of identity he tries to retrieve
Possible Solution
Steps to Reproduce (for bugs)
- Get identity via masternode identity's identifier
- Get first public key from the set
- Try to search the given identity by that specific public key
- Query throws Not Found error
Context
Due recent changes in the code, masternode identities now behave differently from the regular ones, and that breaks getIdentityPublicKeyHash GRPC query.
Your Environment
- Version used:
- Environment name and version (e.g. Chrome 39, node.js 5.4):
- Operating System and version (desktop, server, or mobile):
- Link to your project:
I believe it's by design rather than a bug. The getIdentityByPublicKeyHash endpoint works only for unique keys, but masternode keys aren't unique. Please @QuantumExplorer confirm. @thephez shall we document it somehow?
this should be closed by https://github.com/dashpay/platform/pull/2324
