platform icon indicating copy to clipboard operation
platform copied to clipboard

Test failed Feature Flags contract

Open lordbah opened this issue 1 year ago • 2 comments

Expected Behavior

Tests should pass.

Current Behavior

✖ @dashevo/feature-flags-contract at packages/feature-flags-contract 4.891s ✖ test 4.881s ✖ test:unit 4.864s ✖ $ mocha 'test/unit/**/*.spec.js' 4.779s │ │ │ Feature Flags contract │ 1) "before each" hook for "should have a valid contract definition" │ │ │ 0 passing (2s) │ 1 failing │ │ 1) Feature Flags contract │ "before each" hook for "should have a valid contract definition": │ JsonSchemaError: "position" is a required property, path: /properties/block/properties/maxBytes

Possible Solution

Steps to Reproduce (for bugs)

  1. yarn test

Context

Your Environment

repo cloned as of 5e996edd879222d51b9843a4625a04db4c1b2daf (7-Oct-2024) Built per README PopOS 22.04 (Ubuntu)

lordbah avatar Oct 07 '24 21:10 lordbah

Yeah, feature flags data contract schema is invalid and missing position, I don't know why, most likely has to be forgotten to update. I'm not sure we use this data contract anymore though

pshenmic avatar Oct 08 '24 15:10 pshenmic

We don't use this data contract anymore. We should remove it form repo

shumkov avatar Oct 17 '24 10:10 shumkov