platform icon indicating copy to clipboard operation
platform copied to clipboard

feat(sdk): enable withdrawals v1 in JS SDK

Open shumkov opened this issue 4 months ago • 1 comments

Issue being fixed or feature implemented

We should be able to withdraw credits with JS SDK

What was done?

  • Switched to Identity Credit Withdrawal Transaction V1

How Has This Been Tested?

With test suite against local network

Breaking Changes

None

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added or updated relevant unit/integration/functional/e2e tests
  • [x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • [x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • [x] I have assigned this pull request to a milestone

Summary by CodeRabbit

  • New Features

    • Enhanced flexibility in the credit withdrawal process by making the withdrawal address and output script optional.
    • Introduced new structures for managing withdrawal transitions, accommodating different versions for improved flexibility.
  • Bug Fixes

    • Improved error handling for invalid withdrawal addresses.
  • Documentation

    • Updated method signatures to reflect changes in parameter requirements and added new versioning structures related to identity credit withdrawals.

shumkov avatar Oct 03 '24 09:10 shumkov