fix(dpp): panic when generating more than 12 identity keys

[lklimek]

Issue being fixed or feature implemented

pub fn random_authentication_key_with_private_key_with_rng panics

What was done?

• fixed slice size
• fixed invalid error handling with .unwrap()

How Has This Been Tested?

Using TUI, observed that the panic does not happen anymore.

Breaking Changes

None

Checklist:

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have added or updated relevant unit/integration/functional/e2e tests
• [ ] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• [ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• [x] I have assigned this pull request to a milestone

Summary by CodeRabbit

• New Features

  • Improved key generation logic for enhanced clarity and maintainability.
  • Introduced a constant MAX_RANDOM_KEYS to replace hardcoded values, making the code more adaptable.
  • Expanded testing suite with new test cases for identity management and transaction processing, including scenarios for handling document operations and identity transfers.

• Bug Fixes

  • Adjusted the range for generating random keys to ensure consistency with the new MAX_RANDOM_KEYS constant.
  • Enhanced error handling and logging in tests for better debugging.

[coderabbitai[bot]]

Walkthrough

The changes involve enhancements to the key generation logic within the random.rs files of the IdentityPublicKey and IdentityPublicKeyV0 implementations. A constant MAX_RANDOM_KEYS has been introduced to replace hardcoded values, ensuring better adaptability. The methods have been refined for clarity, including improved input validation and error handling. Additionally, the testing framework for chain execution strategies has been expanded with new test cases and enhanced validations to ensure comprehensive coverage of identity management and transaction processing scenarios.

Changes

Files	Change Summary
packages/rs-dpp/src/identity/identity_public_key/random.rs	Introduced MAX_RANDOM_KEYS constant. Updated main_keys_with_random_authentication_keys_with_private_keys_with_rng for validation checks and refined key generation logic.
packages/rs-dpp/src/identity/identity_public_key/v0/random.rs	Added MAX_RANDOM_KEYS constant to replace hardcoded value 16. Updated methods with input validation and improved error handling.
packages/rs-drive-abci/tests/strategy_tests/main.rs	Added new test cases for identity management and transaction processing. Enhanced existing tests with additional checks and assertions. Improved error handling and logging.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant IdentityPublicKey
    participant IdentityPublicKeyV0

    User->>IdentityPublicKey: Request main keys with random authentication keys
    IdentityPublicKey->>IdentityPublicKey: Validate key count
    IdentityPublicKey->>IdentityPublicKey: Generate keys using updated logic
    IdentityPublicKey-->>User: Return generated keys

    User->>IdentityPublicKeyV0: Request random authentication key
    IdentityPublicKeyV0->>IdentityPublicKeyV0: Validate key count
    IdentityPublicKeyV0->>IdentityPublicKeyV0: Generate key using MAX_RANDOM_KEYS
    IdentityPublicKeyV0-->>User: Return random authentication key

Poem

In the meadow where bunnies play,
New keys hop in a joyful array.
With MAX_RANDOM_KEYS to guide their way,
Clarity shines, come what may!
Hooray for changes, let’s celebrate,
For every key, a new fate awaits! 🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.