platform icon indicating copy to clipboard operation
platform copied to clipboard

chore(dashmate): update Core to 21.2 nightly

Open shumkov opened this issue 1 year ago • 5 comments
trafficstars

Issue being fixed or feature implemented

Update Core to latest nightly to ensure compatibility with Platform

What was done?

  • Updated Core to v21.2.0-nightly.2024.09.04
  • Added config migration

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have added or updated relevant unit/integration/functional/e2e tests
  • [x] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • [x] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • [x] I have assigned this pull request to a milestone

shumkov avatar Sep 04 '24 18:09 shumkov

Do not merge this!

QuantumExplorer avatar Sep 12 '24 11:09 QuantumExplorer

@QuantumExplorer what about now?

shumkov avatar Sep 16 '24 16:09 shumkov

Let's make this for 1.4 only please.

QuantumExplorer avatar Sep 17 '24 13:09 QuantumExplorer

We can't really merge this into production.

QuantumExplorer avatar Sep 26 '24 09:09 QuantumExplorer

https://github.com/dashpay/dash/pull/6247

shumkov avatar Sep 27 '24 06:09 shumkov

Walkthrough

The changes in this pull request involve modifications across several files, primarily focusing on updating migration functions, altering task sequences, and refining error handling. A new migration function for version 1.6.0 is added to update Docker images, while the task factory for configuring core tasks sees the removal and addition of several tasks to streamline the process. Additionally, the reporting of platform activation status is simplified, and error handling is improved in the relevant functions. Overall, these changes enhance the configuration and operational flow of the application.

Changes

File Path Change Summary
packages/dashmate/configs/getConfigFileMigrationsFactory.js - Introduced migration function for version 1.6.0 to update Docker image.
packages/dashmate/src/listr/tasks/setup/local/configureCoreTaskFactory.js - Removed task for activating DIP3.
- Added tasks for "Create wallet" and generating funds for masternodes.
- Updated DIP3 activation height to 901 and V21 fork activation height to 1001.
packages/dashmate/src/status/scopes/platform.js - Modified getPlatformScopeFactory to report activation height instead of time difference.
- Refined error handling in getDriveInfo for ContainerIsNotPresentError.
packages/dashmate/configs/defaults/getBaseConfigFactory.js - Updated Docker image version from dashpay/dashd:21 to dashpay/dashd:22.0.0-rc.1.

Possibly related PRs

  • #2206: Introduces a new migration function for version 1.6.0 that updates Docker images, related to changes in getConfigFileMigrationsFactory.js.
  • #2245: Changes to getPlatformScopeFactory function and error handling relate to improvements in error reporting in this PR.
  • #2255: Addition of protocol version information in the status command is directly related to enhancements made in this PR.
  • #2276: Updates made to seed node configurations align with the addition of new seed nodes in this PR.
  • #2298: Introduction of a cleanup command for ZeroSSL certificates is related to the new CleanupCommand class in this PR.

Suggested reviewers

  • QuantumExplorer
  • pshenmic

🐰 In the meadow, changes bloom,
New tasks and migrations make room.
Docker images, fresh and bright,
Configs updated, all feels right.
With clearer paths and errors tamed,
Our code's a garden, well-named! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 58bfec22088c580e37c7b62096797d0483d1252f and e165edce71d34057d7a63feff3e3cef907481425.

📒 Files selected for processing (1)
  • packages/dashmate/configs/getConfigFileMigrationsFactory.js (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/dashmate/configs/getConfigFileMigrationsFactory.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Oct 29 '24 05:10 coderabbitai[bot]