platform icon indicating copy to clipboard operation
platform copied to clipboard

build: bump Alpine version to 3.20

Open lklimek opened this issue 1 year ago • 1 comments

Issue being fixed or feature implemented

Alpine 3.20 is the most recent version of Alpine, with EOL in 2026-04-01. Current version (3.18) EOL is 2025-11-01, and it only gets security fixes atm.

What was done?

Updated Alpine in Dockerfile to 3.20. Installed missingcurl

How Has This Been Tested?

GHA

Breaking Changes

None

Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have added or updated relevant unit/integration/functional/e2e tests
  • [ ] I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • [ ] I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • [x] I have assigned this pull request to a milestone

lklimek avatar Aug 23 '24 11:08 lklimek

Does not work, needs update of rocksdb on grovedb OR more work on c++ stack.

lklimek avatar Sep 04 '24 08:09 lklimek

Walkthrough

The Dockerfile has been updated to manage dependencies and adjust the build environment. Changes include updating the Alpine Linux base version, adding a new build argument, and correcting a build argument name. Modifications to package installation commands ensure that updated versions of clang and llvm are used and that the appropriate symbolic links and environment variables are set. Additional commands install curl in the deps-base stage, copy the RocksDB static library in the deps-rocksdb stage, and unset compiler flags in the build-js stage for WebAssembly builds.

Changes

File Change Summary
Dockerfile - Updated ALPINE_VERSION from 3.18 to 3.21
- Added build argument CARGO_BUILD_PROFILE=dev
- Corrected build argument name from SCCHACHE_VERSION=0.8.2 to SCCACHE_VERSION=0.8.2
- Modified apk add commands to use clang18-static clang18-dev and llvm18-static llvm18-dev
- Added installation of curl in the deps-base stage
- Configured symbolic links for clang and clang++ and set CC/CXX environment variables
- Copied librocksdb.a in the deps-rocksdb stage
- Unset CFLAGS and CXXFLAGS in the build-js stage for WASM32 builds

Possibly related PRs

  • dashpay/platform#2374: Modifies the Dockerfile for Rust toolchain management and build profiles, directly relating to dependency and build configuration updates.

Suggested Reviewers

  • QuantumExplorer
  • shumkov

Poem

I'm a rabbit, nibbling code with glee,
Dockerfile tweaks set the build process free.
Dependencies updated, flags cleared with style,
Hop along the pipelines, mile after mile.
Celebrate these changes with a joyful smile!
🐰💻🌟


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1bd61b3b14550d9bdba797f562d7fc199a734657 and d21f878bc14072d8c91ca39b44896851fab31b97.

📒 Files selected for processing (1)
  • Dockerfile (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms (14)
  • GitHub Check: Release Test Suite image / Build linux/arm64 image
  • GitHub Check: Release Test Suite image / Build linux/amd64 image
  • GitHub Check: Release Drive debug image / Build linux/arm64 image
  • GitHub Check: Release DAPI image / Build linux/arm64 image
  • GitHub Check: Release Drive debug image / Build linux/amd64 image
  • GitHub Check: Release Dashmate Helper image / Build linux/arm64 image
  • GitHub Check: Release DAPI image / Build linux/amd64 image
  • GitHub Check: Release Drive image / Build linux/arm64 image
  • GitHub Check: Release Dashmate Helper image / Build linux/amd64 image
  • GitHub Check: Release Drive image / Build linux/amd64 image
  • GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
  • GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
  • GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
  • GitHub Check: Build JS packages / Build JS

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Dec 17 '24 09:12 coderabbitai[bot]