platform icon indicating copy to clipboard operation
platform copied to clipboard

feat(dashmate): warn user if the node is participating in DKG sessions

Open pshenmic opened this issue 1 year ago • 5 comments

Expected Behavior

Warn user if masternode is participating or going to participate in the DKG session soon when user want to stop or restart the node

Current Behavior

If user restart core service during DKG session, it will likely receive a POSE ban. We should warn the user about that so that he would choose different restart time window

Possible Solution

We can calculate time window with the given formula: image

pshenmic avatar Dec 26 '23 21:12 pshenmic

dashmate core cli 'quorum memberof protxhash 1' looks to be working too. For one of my Evonodes it got me the following info

[ { "height": 1994688, "type": "llmq_400_85", "quorumHash": "000000000000002a53ea06c15f70cae721df535248b57e2309bfd5a804db308d", "quorumIndex": 0, "minedBlock": "0000000000000016120c7ea58eb08c7f94c1cc8d65bc05f62b0714a767af3f89", "quorumPublicKey": "ae91eb264b4cf80393c263abdfaf78120c4e3526d009b8de0b59a2121ea736bd6ba2934fdd6049b74bc9215164d2a690", "isValidMember": true, "memberIndex": 95 }, { "height": 1994832, "type": "llmq_100_67", "quorumHash": "0000000000000021220668e034d3fb1820cde45a7d5b888955a9df08b7ee8698", "quorumIndex": 0, "minedBlock": "00000000000000133dc849c9256709d8e09d0fe139b9882cc97efab6341ef702", "quorumPublicKey": "80aa22fd2b772e9af977d7d230ad48519bdbbf2a8db3e0201aa5ef1d0665c68f82c16f96c4e11fbbd56d91a8365053f1", "isValidMember": true, "memberIndex": 20 } ]

So two quorum involvements currently (llmq 400_85 & llmq 100_67), for this specific Evonode. Not sure if these two llmq quorums will also be giving high PoSe Penalty scores (DKG), when getting interrupted by a Dashmate restart.

qwizzie avatar Dec 27 '23 16:12 qwizzie

@qwizzie

Unfortunately, udjin says that it only shows mined DKG windows, in other words that alread have passed

pshenmic avatar Dec 27 '23 21:12 pshenmic

Warn user if masternode is participating or going to participate in the DKG session soon when user want to stop or restart the node

Unfortunately, udjin says that it only shows mined DKG windows, in other words that alread have passed

@pshenmic does it mean that we still can warn user if masternode is participating in the current DKG session (but not future)?

knst avatar Dec 27 '23 22:12 knst

Knipsel

I guess we will need a new Evo RPC that Dashmate can use to check if a specific Masternode / Evonode is currently involved (before mined) in LLMQ_50_60 (?), LLMQ_100_67, LLMQ_60_75

LLMQ_50_60 is consistently failing to initiate according my core.logs, seems connected to DIP24 somehow ? So maybe this LLMQ does not need to be included.

Not sure if LLMQ_400_60 is involved with high PoSe Penalty DKG scores, UdjinM6 mentioned (/24)*24 & (/288)*288 so that could also include LLMQ_400_60

qwizzie avatar Dec 28 '23 07:12 qwizzie

Interim solution (untill this gets tackled on protocol level) : https://www.dash.org/forum/index.php?threads/llmq-pose-check-on-your-evonode-or-masternode-setup-through-dashmate.54445/#post-237453

qwizzie avatar Jan 06 '24 14:01 qwizzie