broadway_sqs icon indicating copy to clipboard operation
broadway_sqs copied to clipboard

Add client options for configuring a connection pool

Open mcrumm opened this issue 6 years ago • 2 comments

As we did for Cloud Pub/Sub (plataformatec/broadway_cloud_pub_sub#37), should we look to implement pipeline-specific connection pools for BroadwaySQS?

I was about to start on a PR for this when I realized it might be a little more involved than the Pub/Sub change, as we don't have a hard requirement on :hackney here. Should we add one?

mcrumm avatar Nov 07 '19 18:11 mcrumm

Not sure. I remember we've discussed some time ago that since broadway producers already work as a pool, the best approach would be to use something like Mint. I'm sceptical that adding these options now would bring any real benefit but I might be wrong. We would need some real benchmark to make sure :)

msaraiva avatar Nov 07 '19 19:11 msaraiva

So my recommendation is to use github.com/keathley/finch which is still a pool but without the extra copying. :)

josevalim avatar Aug 13 '20 18:08 josevalim