broadway_cloud_pub_sub icon indicating copy to clipboard operation
broadway_cloud_pub_sub copied to clipboard

Handle messages without data

Open mcrumm opened this issue 9 months ago • 2 comments

Messages with payloadFormat: "NONE" may not contain the data attribute. Note something may have changed on Google's side because I believe this was previously handled by the nil check.

Closes #98

mcrumm avatar May 02 '24 19:05 mcrumm

@wojtekmach We could get more specific and pattern match on the message attributes but I am not sure there is much virtue in it. What do you think?

mcrumm avatar May 02 '24 19:05 mcrumm

We could get more specific and pattern match on the message attributes

The benefit of doing that is that, if there is a new format in the future, we won't try to accidentally decode without knowing what it actually is.

josevalim avatar May 02 '24 20:05 josevalim