dash icon indicating copy to clipboard operation
dash copied to clipboard

Published 20 hours ago • verified publisher icon dash-project

[WIP]Fix MatrixRef::lbegin/lend

Open devreal opened this issue 7 years ago • 4 comments

This PR fixes two issues with MatrixRef lbegin/lend:

  1. Fixed compiler error
  2. Fixed lend() in LocalMatrixRef (and thus MatrixRef) to not return a nullptr but a pointer past the end of the range (GlobViewIter::local() returns nullptr if pointing beyond the current unit)

devreal avatar Aug 03 '17 12:08 devreal

The offsets are still broken and I cannot seem to figure out which offsets to use. Will look at it again tomorrow... Any help is appreciated, though.

devreal avatar Aug 03 '17 15:08 devreal

@fuchsto I'm giving up here as it is not clear to me anymore which are global and local block coordinates and indexes. Also, I suspect that there are fixes lingering around in your branches. I'd appreciate a timely merge or a quick fix as the broken lbegin() on blocks is a road block for me right now.

devreal avatar Aug 04 '17 12:08 devreal

@devreal Sorry, I don't get it: what's the original issue? Is the use case covered in the unit test you added? I found a bug related to #418 and will fix it in a separate PR, not sure if it helps your use case.

fuchsto avatar Sep 20 '17 03:09 fuchsto

Sorry, I don't get it: what's the original issue?

This PR was my attempt to fix Matrix::lbegin a month after I reported the issue in #418 but I got lost in the usage of CartesianIndexSpace (does it hold local or global indexes? pretty confusing for me) My original use case should be covered by the test case I added here.

devreal avatar Oct 01 '17 18:10 devreal