Daniel Santiago

Results 14 comments of Daniel Santiago

Is there any reason the above PR has not been merged in yet?

Please can the maintainers provide some feedback on this? Like @bryanrideshark, I agree that either proposed solution would be fine, although I feel like @bryanrideshark solution is cleaner, as long...

> Hi @dasco144 , thanks for the PR! Just wanted to say it'll probably be ~few days/this weekend before I get a chance to look at it. Thanks! Let me...

I realised I did not update the `[README.markdown](https://github.com/stephenh/ts-proto/blob/main/README.markdown)` explaining this setting. I'll create a new PR to add this

I think this might be a nice feature to add. We could include additional information, like how the `protoc-gen-go` plugin does ```ts // Code generated by protoc-gen-go. DO NOT EDIT....

I'd be willing to take a stab at this

@stephenh I've got an PR ready for review 🙏

I can try rebase and get the builds passing if you're busy @stephenh

I managed to fix the error in the lint check, but the [build check ](https://github.com/dasco144/ts-proto/actions/runs/8712921825/job/23900259881#step:7:16)I'm not so sure about. When I run `yarn build:test` the output remains the same, and...