Daniel Schürmann

Results 597 comments of Daniel Schürmann

> So I thought the hotcues and (visual) overview seeking should be 'frozen' as well. Yes it is frozen with the last state. And when you load another track during...

The solution I have implemented is crossfading from one setting to the other. This doubles the CPU load for one buffer, which may cause a buffer underrun which clicks as...

Yes, I am sorry. This PR is IMHO not in a merge-able state, because it doubles the CPU for the zero crossing cycle and does according your tests not solve...

It would be interesting how a mingw gcc build will perform. We may also consider to make sample.cpp a library and compile only this with a different compiler.

I have just tested with the 2.3 and the control is implemented on top of keylock. It is not changed if the pitch is adjusted by keylock. For my understanding...

Here is the manual update: https://github.com/mixxxdj/manual/pull/480

> Unfotunately the current behaviour is inconsistent: > * the knob is static when I "lock at original pitch" after pitch_adjustments (though it doesn't reset to original key, for that...

> Yes, I'd expect that that the pitch is reset to default, OK, I have no objection to this change. It may actually feel more natural, even though it is...

Yes, I did also consider this. This way we can get out 2.3.2 in de upcoming week or such.