Daniel Schürmann
Daniel Schürmann
Yes, you are probably right. Than let's stick with the dynamic allocation. This is beneficial if we think to 64 Sampler skins.
We have a conflict now. Sorry.
Here is the complete compiler output: ``` src/util/sample.cpp:125:24: optimized: loop vectorized using 16 byte vectors src/util/sample.cpp:146:27: optimized: loop vectorized using 16 byte vectors src/util/sample.cpp:154:27: optimized: loop vectorized using 16 byte...
Review is in progress.
> ... 8 individual mono or is it best to treat them as 4 stereo channels. That is not a question IMHO, because mono Rubberband destroys the stereo effect and...
> Isn't it a problem we accepted to go with anyway in https://github.com/mixxxdj/mixxx/pull/13143 and with the user prompt about it? Yes. > My thoughts was, if the benchmark shows better...
Thank you. Just left some final comments. We have also a conflict.
I think the best way would be to make `find_package(Sleef COMPONENTS sleefdft)` This can be done by adding the following fo FindSleef.cmake ``` foreach (_component ${SLEEF_FIND_COMPONENTS}) if (${_component} STREQUAL "sleefdft")...
Fixed by amend.
Oh, I have realized I did this PR again. Now I have rebased the new version onto the old. Hope it is good now.