Daniel Schürmann

Thank you. I think we can go out of draft state and ask for a second pair of unbiased eyes for review.

This LGTM. @fatihemreyildiz can you rebase out the experimental commits?

I already did a detailed review. We just need a second pair of eyes that I have not missed something obvious, because I am probably biased. @ronso0 so if there...

Any Idea why CI is not running? I will try a rebase.

Ci is working now: ``` Warning: res/qml/Mixxx/Controls/Knob.qml:113:21: Type not found in namespace value = Mixxx.MathUtils.clamp(value, 0, 1); ^^^^^^^^^^^^^^^ Warning: res/qml/Mixxx/Controls/WaveformOverview.qml:12:5: Cannot assign to non-existent default property Mixxx.ControlProxy { ^^^^^ Warning:...

What are the pros and cons to have qmllint running with the all target? Compared to the qmllint during the pre commit hook, this one is called from the correct...

It turns out that the pre-commit hook calls qmllint from qt5 which produces false positives. qmllint form qt6 needs to be called with the correct include paths. They are only...

Arch CI failure is fixed here: https://github.com/mixxxdj/mixxx/pull/4680

What would be the solution? I think it would be straight forward to add a module for the skin as well. We can skip it during linking and use the...

Thank you, the code looks good. I think this patch suits to go to the 2.3 branch. Unfortunately the pre-commit hook is complaining. You may apply the pre-commit.patch found here...