Daniel Schürmann

Results 597 comments of Daniel Schürmann

I am afraid a FIFO will have issue with the ramping. When the delay changes.

Here we use https://github.com/mixxxdj/mixxx/blob/d5cf277e73ea96f68c366ce418431f18a4598406/src/soundio/sounddevicenetwork.cpp#L147 aquireWriteRegions() interface. This is the fastest solution and works by luck with ramping. It is based on the PortAudio Ringbuffer and uses memcopy internally which is...

> Right. The issue with the FIFO I didn't consider was what happens when the delay is shortened. Yes right, thinking again about this, a normal FIFO will fail, because...

Thank you very much for this PR. I think Mixxx can learn a lot more form Sayonara :-) I am sorry but we have to first clarify some legal topics:...

We have also to consider that the DJ does not have internet connection. So maybe we should allow to fetch the similar artist info during track analysis, which can be...

OK, so in this case we can continue here, thank you.

A rebase version of this branch can be found here: https://github.com/mixxxdj/mixxx/pull/4885

You probably need to re-target this PR against main. Else all main commits will go to the 2.3 branch.

Thank you. Unfortunately the pre-comit hook fails. You van apply the patch found here https://github.com/mixxxdj/mixxx/actions/runs/2196709533 to fix the issue. In future I recommend to install pre-commit locally as described here:...