sipi icon indicating copy to clipboard operation
sipi copied to clipboard

Published 20 hours ago • verified publisher icon dasch-swiss

Tests for Lua Routes

Open tobiasschweizer opened this issue 7 years ago • 5 comments

I saw that you moved the config files and tests for Knora Lua scripts into the Knora integration tests. That's very good since Sipi should not contain Knora specific things!

However, I do not know if the python tests are stilled used for Sipi:

https://github.com/dhlab-basel/Sipi/blob/f9f5380c6b7d31cfa0df7fc58bb504a00aa5df36/test/e2e/test_02_server.py#L37-L43

These tests cannot be run anymore because these routes do not exist in the Sipi repo anymore.

While test_mediatype is clearly Knora specific, test_functions could probably remain in the Sipi repo. What do you think?

tobiasschweizer avatar Jun 28 '18 09:06 tobiasschweizer

In a Motorola Moto G the test would never pass without this fix. The number of spaces and \n characters vary between Android devices.

Is it going to be merged at any moment?

dfernandezm avatar Jun 21 '14 00:06 dfernandezm